fix(ci): restore green board — web build bugs + gate credentialed workflows #4079
Cross-repo impact
See what breaks downstream if this PR merges.
⮌ Merged
This pull request was merged into main.
c comment · e edit title · m merge · a approve · r request changes · ? shortcuts
Originally written by @ccantynz-alt on GitHub.
Imported from https://github.com/ccantynz-alt/AlecRae.com/pull/52
Why
The Actions board went red after the #49 merge (which landed with broken web CI) plus several workflows fail for lack of credentials. This restores green.
1. Real bugs from #49 (web build chain — each masked the next)
Pricing.tsx— unusedfadeUpvariable →no-unused-vars(Lint) ✅ removedPricing.tsx— used<Reveal>without importing it → 6×TS2552(Typecheck) ✅ addedimport { Reveal } from "./Reveal"checkout/page.tsx—useSearchParams()without a Suspense boundary → prerender failure (Build) ✅ wrapped in<Suspense>Verified locally:
@alecrae/weblint ✓, typecheck ✓, build ✓ (46 pages).2. Gate credential-dependent workflows (Craig: "gate them")
These failed on push because their secrets aren't set, and they're off-stack now that deployment is moving to Vapron (no dependence on Render/Vercel/Cloudflare):
workflow_dispatch(manual) only; need Expo/Apple/Google secrets.workflow_dispatchonly; needs Apple/Windows code-signing.ENABLE_VERCEL_DEPLOYrepo var (default off = skipped).Quality/lint/typecheck/build still run on every PR — only the credentialed build/deploy jobs are gated.
https://claude.ai/code/session_01McgJLnTbZG9mwhfwd5iAX3