CodeIssuesPull RequestsActionsSecurityInsights
✨ AI
More
Settings

fix(ci): restore green board — web build bugs + gate credentialed workflows #4079

Merged⚡ AI-generatedXSccantynz wants to mergeclaude/fix-web-lint-pricingmainopened Jun 9, 2026
ccantynzcommented Jun 9, 2026

Originally written by @ccantynz-alt on GitHub.
Imported from https://github.com/ccantynz-alt/AlecRae.com/pull/52


Why

The Actions board went red after the #49 merge (which landed with broken web CI) plus several workflows fail for lack of credentials. This restores green.

1. Real bugs from #49 (web build chain — each masked the next)

  • Pricing.tsx — unused fadeUp variable → no-unused-vars (Lint) ✅ removed
  • Pricing.tsx — used <Reveal> without importing it → 6× TS2552 (Typecheck) ✅ added import { Reveal } from "./Reveal"
  • checkout/page.tsxuseSearchParams() without a Suspense boundary → prerender failure (Build) ✅ wrapped in <Suspense>

Verified locally: @alecrae/web lint ✓, typecheck ✓, build ✓ (46 pages).

2. Gate credential-dependent workflows (Craig: "gate them")

These failed on push because their secrets aren't set, and they're off-stack now that deployment is moving to Vapron (no dependence on Render/Vercel/Cloudflare):

  • Mobile iOS / Androidworkflow_dispatch (manual) only; need Expo/Apple/Google secrets.
  • Desktopworkflow_dispatch only; needs Apple/Windows code-signing.
  • Standalone "Deploy via Vercel" → gated behind ENABLE_VERCEL_DEPLOY repo var (default off = skipped).

Quality/lint/typecheck/build still run on every PR — only the credentialed build/deploy jobs are gated.

https://claude.ai/code/session_01McgJLnTbZG9mwhfwd5iAX3

Cross-repo impact

See what breaks downstream if this PR merges.

Analyze →
⮌ Merged

This pull request was merged into main.

c comment · e edit title · m merge · a approve · r request changes · ? shortcuts