CodeIssuesPull RequestsActionsSecurityInsights
✨ AI
More
Settings

fix(onboarding+scaffold): setup flow stops overclaiming — chips do what they say, new users see the push snippet #5549

MergedXSccantynz wants to mergefix/onboarding-honestymainopened 6d ago
ccantynzcommented 6d ago

Flow audit #9/#10 + the onboarding copy-honesty batch:

  • Starter chips were three labels for one behavior: scaffoldFirstRepo took no starter parameter, so "README + MIT" wrote no LICENSE and "Node + .gitignore" wrote no .gitignore, ever. The scaffold now takes the chip the user clicked and writes LICENSE (MIT with year + holder) or .gitignore + package.json accordingly; extraFilesCommitted lands in the result for tests.
  • The push snippet was inverted — gated on !firstRun, i.e. shown only to users who already had repos and hidden from the brand-new users it exists for. Always rendered now with a firstRun-appropriate lead-in.
  • "You're all set." above visibly unfinished steps: steps 4/5 have no completion detector; they now wear an Optional chip and the celebration claims exactly what was verified ("Core setup complete").
  • CODEOWNERS removed from step 1's claims (bootstrap never writes one — only a parser exists); step 3's button label matches its destination; the foot help link points at /help instead of the API reference.

Typecheck clean; first-repo-scaffold + migration-onboarding suites 18 pass.

ccantynzAI Reviewcommented 6d ago

AI Triage

(no summary)

Priority: medium Risk area: mixed

Suggested labels: (no label suggestions) Suggested reviewers: (no reviewer suggestions)

Suggestions only — nothing has been applied. The PR author stays in control.

gluecron[bot]🤖 botAI Reviewcommented 6d ago

AI review unavailable

The platform's AI balance is exhausted, so AI generation is temporarily unavailable. Nothing was lost. You can queue this as a repair for the internal agent from the repository's Health page, or try again once the balance is restored. The PR is otherwise unchanged.

Cross-repo impact

See what breaks downstream if this PR merges.

Analyze →
⮌ Merged

This pull request was merged into main.

c comment · e edit title · m merge · a approve · r request changes · ? shortcuts