CodeIssuesPull RequestsActionsSecurityInsights
✨ AI
More
Settings

chore(hygiene): NUL byte in repository.ts, hourly mirror warning, dead deploy workflows removed #5511

Merged⚡ AI-generatedXSccantynz wants to mergechore/estate-hygienemainopened 10d ago
ccantynzcommented 10d ago

Findings 3 + 4 from the Vapron instance's briefing, fixed

  1. src/git/repository.ts is a text file again. One raw NUL byte inside a cache-key template literal made grep/file(1) treat ~3,000 lines of load-bearing git plumbing as binary (it bit me mid-investigation this week too — and it just bit a third time by making the first attempt at THIS pull request fail: Postgres refuses NUL in text, so the PR body couldn't even mention the byte literally). Replaced with the backslash-u0000 escape — byte-identical string value at runtime.
  2. Zero-mirrors warning: hourly instead of every 5-minute tick. The every-tick honesty (288/day) had crossed into noise operators learn to filter — the exact failure mode the warning exists to prevent. Message unchanged, rate-limited, with an explicit "(Repeats hourly while true.)" suffix. Mirror-sync failure test still passes.
  3. Deleted .github/workflows/hetzner-deploy.yml and fly-deploy.yml per Craig — Hetzner is gone for months and not coming back. heartbeat.yml (the one live GitHub job) untouched. Stale references to hetzner-deploy in rollback-deploy.ts/admin-deploys-page.tsx were already dead paths — follow-up, not smuggled into a hygiene pass.

Typecheck clean; targeted tests green.

🤖 Generated with Claude Code

ccantynzAI Reviewcommented 10d ago

AI Triage

(no summary)

Priority: medium Risk area: mixed

Suggested labels: (no label suggestions) Suggested reviewers: (no reviewer suggestions)

Suggestions only — nothing has been applied. The PR author stays in control.

gluecron[bot]🤖 botAI Reviewcommented 10d ago

AI review unavailable

The platform's AI balance is exhausted, so AI generation is temporarily unavailable. Nothing was lost. You can queue this as a repair for the internal agent from the repository's Health page, or try again once the balance is restored. The PR is otherwise unchanged.

Cross-repo impact

See what breaks downstream if this PR merges.

Analyze →
⮌ Merged

This pull request was merged into main.

c comment · e edit title · m merge · a approve · r request changes · ? shortcuts