fix(gates+ci): security scan actually runs; workflow branch filters honored; deploy workflow verifies reality #5465
ccantynzAI Reviewcommented 24d ago
AI Triage
(no summary)
Priority: medium Risk area: mixed
Suggested labels: (no label suggestions) Suggested reviewers: (no reviewer suggestions)
Suggestions only — nothing has been applied. The PR author stays in control.
gluecron[bot]🤖 botAI Reviewcommented 24d ago
AI review unavailable
The platform's AI balance is exhausted, so AI generation is temporarily unavailable. Nothing was lost. You can queue this as a repair for the internal agent from the repository's Health page, or try again once the balance is restored. The PR is otherwise unchanged.
Cross-repo impact
See what breaks downstream if this PR merges.
⮌ Merged
This pull request was merged into main.
c comment · e edit title · m merge · a approve · r request changes · ? shortcuts
Two owner questions, one root theme — subsystems that never actually ran:
The AI security scan never ran on any PR. It requires
diffTextand no call site ever passed it — every gate panel showed "Skipped — no diff provided" since the feature shipped.runAllGateChecksnow computes thebase...headdiff itself (150k-char bound, 20s timeout, degrades to skipped), so all three merge paths + the PR page get a real scan. Skip messages made honest ("Disabled in settings" / "Skipped — no changes to scan"). Note: the scan is AI-backed, so until the Anthropic balance is restored it will report "unavailable — not blocking" — honestly.on: push: branches: [main]was parsed and discarded — every push workflow fired on every branch: 254 consecutive junk failures on the deploy workflow. The parser now carriespushBranches; the push sync skips non-matching branches.deploy.yml rewritten as "Verify deploy to production" — it used to attempt a script that has never existed in the runner; it now polls
/api/versionfor its own commit (6 min), succeeding when the timer-based deploy actually ships it and failing only when the deploy pipeline is genuinely stuck.tsc clean; gate/scan/workflow suites green (3 pre-existing failures identical on main).
🤖 Generated with Claude Code