CodeIssuesPull RequestsActionsSecurityInsights
✨ AI
More
Settings

fix(status): the dead-server claim renders only when the off-box writer is armed #5552

MergedXSccantynz wants to mergefix/status-heartbeat-honestymainopened 6d ago
ccantynzcommented 6d ago

Owner asked whether the 100%/90+ figures are real. They are real arithmetic — over an incomplete ledger: HEARTBEAT_REPORT_TOKEN is unset in production, so the off-box incident writer 401s every call (deliberate fail-closed per heartbeat-report.ts) and has never been able to file. The Aug 22 full-box outage therefore never landed as an incident, and the page's unconditional claim that "a dead server still shows as downtime here" was false in practice.

The claim now renders only when the token is armed; while unarmed, the page says plainly that the figures are a floor on downtime, not a ceiling. Arming the token (box env + workflow secret, both sides) is an owner action — secrets never transit this channel.

Typecheck clean; status + heartbeat suites 49 pass.

ccantynzAI Reviewcommented 6d ago

AI Triage

(no summary)

Priority: medium Risk area: mixed

Suggested labels: (no label suggestions) Suggested reviewers: (no reviewer suggestions)

Suggestions only — nothing has been applied. The PR author stays in control.

gluecron[bot]🤖 botAI Reviewcommented 6d ago

AI review unavailable

The platform's AI balance is exhausted, so AI generation is temporarily unavailable. Nothing was lost. You can queue this as a repair for the internal agent from the repository's Health page, or try again once the balance is restored. The PR is otherwise unchanged.

Cross-repo impact

See what breaks downstream if this PR merges.

Analyze →
⮌ Merged

This pull request was merged into main.

c comment · e edit title · m merge · a approve · r request changes · ? shortcuts