feat(nav): one canonical RepoNav — data-derived keys, insights sub-nav unified, lost pages find their way home #5550
ccantynzAI Reviewcommented 6d ago
AI Triage
(no summary)
Priority: medium Risk area: mixed
Suggested labels: (no label suggestions) Suggested reviewers: (no reviewer suggestions)
Suggestions only — nothing has been applied. The PR author stays in control.
gluecron[bot]🤖 botAI Reviewcommented 6d ago
AI review unavailable
The platform's AI balance is exhausted, so AI generation is temporarily unavailable. Nothing was lost. You can queue this as a repair for the internal agent from the repository's Health page, or try again once the balance is restored. The PR is otherwise unchanged.
Cross-repo impact
See what breaks downstream if this PR merges.
⮌ Merged
This pull request was merged into main.
c comment · e edit title · m merge · a approve · r request changes · ? shortcuts
Queue item: the flow audit's navigation-coherence findings (#4, #7 and the active-key list), built to the ADMIN_NAV standard.
REPO_NAV_PRIMARY/REPO_NAV_AI_GROUPS/REPO_NAV_MORE/REPO_NAV_SETTINGS); theRepoNavKeyunion is derived from the arrays, so the type and the rendered menus agree by construction — the two dead union members are gone and the nine menu destinations that could never highlight now can.InsightsSubNavcomponent replaces seven mutually inconsistent hand-rolled strips (dora.tsx, which had NO sub-nav and was a terminal node, gets one too). All seven destinations reachable from every insights page, tokens only.active=fixed across the AI pages (which were funneling through IssueNav's 3-key type), contributors, docs-tracking, previews. (packages.tsxwas already correct — the audit's claim didn't survive verification.)aria-current="page"at every RepoNav render site, matching SettingsNav.repo-nav-coherence.test.ts(26 tests) renders RepoNav from the exported data for every key and asserts exactly onearia-currentanchor with the canonical href — data-driven both directions, unlike the source-string guards that passed while these defects persisted.Deliberately scoped out (follow-up): deployments' two detail sub-pages and wikis' six sub-pages.
Verified on current main after cherry-pick: typecheck clean; repo-nav-coherence + nav-tab-fixes + orphan-links + adjacent suites 48 pass locally, full suite in CI.