CodeIssuesPull RequestsActionsSecurityInsights
✨ AI
More
Settings

chore(design): Wave 0 — fix the measuring instrument, delete 9,100 lines of dead views #5544

MergedXSccantynz wants to mergechore/design-wave0mainopened 6d ago
ccantynzcommented 6d ago

First executable slice of the aggressive design audit (owner directive 2026-08-27: "test test test… we need to lift our game").

The audit script was wrong in both directions. Its banned-purple window (hue 250–300) didn't match the law design-tokens.ts documents (indigo AND violet): #a5b4fc, #3730a3, #1e40af and a dozen other live purples were invisible to the instrument built to catch them, while HTML arrow entities (→), PR numbers in prose (#204), and a comment describing an already-removed purple scored as violations. Fixed: window 225–305, chroma ≥ 0.10 floor (near-black navies aren't "purple"), comments/entities stripped, 3-digit hex requires a CSS-looking line. Corrected truth: 62 real banned literals (was 49, ~9 fake, ~22 invisible).

Seven unrouted view files deleted (~9,100 lines, ~420 literals): pr-redesign, ide-multiplayer, fleet-refactor, onboarding-v2, plan-approval, landing, landing-2030 — each verified to have zero live importers (landing/landing-2030 were void-imported; those imports are gone too). The three test files that exercised the dead LandingPage keep only their live GET / contracts; the error-beacon EXEMPT list empties. distribution.tsx loses "See a live editor session →" — it pointed at /ide-multiplayer, a route that never existed (live 404 confirmed).

Verified: typecheck clean; public-stats/landing-hero/landing-live-feed/error-beacon/u-polish suites 40 pass.

Next waves (queued, from the two audit reports): Wave 1 mechanical token swaps (~1,100 sites, scriptable), Wave 2 tokenless-page rebuilds, plus the flow audit's criticals (empty-repo CTA 404, unenforced branch-protection toggles) which rank above all design work.

ccantynzAI Reviewcommented 6d ago

AI Triage

(no summary)

Priority: medium Risk area: mixed

Suggested labels: (no label suggestions) Suggested reviewers: (no reviewer suggestions)

Suggestions only — nothing has been applied. The PR author stays in control.

gluecron[bot]🤖 botAI Reviewcommented 6d ago

AI review unavailable

The platform's AI balance is exhausted, so AI generation is temporarily unavailable. Nothing was lost. You can queue this as a repair for the internal agent from the repository's Health page, or try again once the balance is restored. The PR is otherwise unchanged.

Cross-repo impact

See what breaks downstream if this PR merges.

Analyze →
⮌ Merged

This pull request was merged into main.

c comment · e edit title · m merge · a approve · r request changes · ? shortcuts