CodeIssuesPull RequestsActionsSecurityInsights
✨ AI
More
Settings

fix(restore-drill): chown extracted scratch tree so fsck actually runs #5507

Merged⚡ AI-generatedXSccantynz wants to mergerestore-drill-ownershipmainopened 12d ago
ccantynzcommented 12d ago

What broke

The first offsite-sourced drill (2026-08-20, after wiring EnvironmentFile into the drill unit) "failed" all 48 repos — but not one fsck ever ran. Root extracting the tarball restores the archived container UIDs, and git refuses repos owned by another UID (detected dubious ownership). The DB half passed cleanly from the offsite copy (pull_requests drift 1 within tolerance 353 — the Aug-16 false alarm is gone).

Fix

  • chown -R the scratch extraction tree to the drill user after tar -xzf (no-op when tar already extracted as us; || true so a partial chown can't change the verdict on its own).
  • Belt-and-braces: git -c safe.directory='*' on the fsck call.

bash -n clean. The spawn-based test harness can't run on the Windows dev box (no bash in Bun's PATH — the known runner-sandbox exclusion); the merge-gate CI runs it for real.

This is the last red gate before the cutover runbook's Phase 1 is provably green from the offsite copy.

🤖 Generated with Claude Code

ccantynzAI Reviewcommented 12d ago

AI Triage

(no summary)

Priority: medium Risk area: mixed

Suggested labels: (no label suggestions) Suggested reviewers: (no reviewer suggestions)

Suggestions only — nothing has been applied. The PR author stays in control.

gluecron[bot]🤖 botAI Reviewcommented 12d ago

AI review unavailable

The platform's AI balance is exhausted, so AI generation is temporarily unavailable. Nothing was lost. You can queue this as a repair for the internal agent from the repository's Health page, or try again once the balance is restored. The PR is otherwise unchanged.

Cross-repo impact

See what breaks downstream if this PR merges.

Analyze →
⮌ Merged

This pull request was merged into main.

c comment · e edit title · m merge · a approve · r request changes · ? shortcuts