fix(issues): design-audit fixes for issues surfaces (issue #211) #5458
ccantynzAI Reviewcommented 24d ago
AI Triage
(no summary)
Priority: medium Risk area: mixed
Suggested labels: (no label suggestions) Suggested reviewers: (no reviewer suggestions)
Suggestions only — nothing has been applied. The PR author stays in control.
gluecron[bot]🤖 botAI Reviewcommented 24d ago
AI review unavailable
The platform's AI balance is exhausted, so AI generation is temporarily unavailable. Nothing was lost. You can queue this as a repair for the internal agent from the repository's Health page, or try again once the balance is restored. The PR is otherwise unchanged.
Cross-repo impact
See what breaks downstream if this PR merges.
⮌ Merged
This pull request was merged into main.
c comment · e edit title · m merge · a approve · r request changes · ? shortcuts
Part of the visual-audit sweep for #211 — ISSUES surfaces slice.
Defects fixed
1. WORST-PAGE #1 — issue detail page squeezed into the left half of wide viewports
src/views/layout.tsxhad.issue-detail { max-width: 920px; }with no auto margins, inside a 1920px-widemain..issue-detail { max-width: 1080px; margin: 0 auto; }— a centered readable container. With the 240px metadata sidebar, the body column lands at ~800px of comfortable reading width..issue-detailis used only by the issues detail template, so no other surface is affected.2. BROKEN — issues list search placeholder displayed the literal text
Search issues…placeholder="Search issues…"— JSX attribute string literals do not process JS unicode escapes, so the six characters…rendered verbatim in the input.placeholder={"Search issues…"}— an expression container, where the escape is evaluated by JS and renders as a real ellipsis (…). Matches the file's existing idiom for unicode glyphs ({"○"}etc.).3. Bunching on the issues list rows
var(--border-subtle)token (withvar(--border)fallback) per the Natural Light standard.var(--bg-hover)token instead of an accent color-mix.6px 10pxso label pills and epic/child tags no longer touch the title text when wrapping.margin-top: 5px → 7px) so "#N opened by …" no longer crowds the title.margin-top: 4pxto baseline-align with the state icon and title.Row padding was already at the standard's 14px/18px, and hover + last-child border removal already existed — kept as-is.
Verification
bunx tsc --noEmit -p .— clean.bun test src/__tests__ --test-name-pattern "issue"— 119 pass, 0 fail (100 pattern-skips, pre-existing).Tokens only, no hardcoded colors, no purple.
🤖 Generated with Claude Code