CI: re-include the 21 excluded test files (subprocess PATH + env-sensitive audits)#213
○Openccantynz opened this issue 23d ago
ccantynzAuthorcommented 23d ago
scripts/ci-test-excludes.txt currently excludes 21 files (60 tests), found empirically by CI runs #2–#3. Two classes, two fixes:
Class A — subprocess spawns (10 files): tests that Bun.spawn bun/bash/git fail with "Executable not found in $PATH" inside the runner sandbox but pass in dev shells. Fix: a shared test helper that resolves absolute executable paths (Bun.which("bash") at test setup with a skip-if-absent guard), or export a full PATH in the runner env. Then delete the class-A block from the excludes file.
Class B — env-sensitive assertions (11 files): admin bootstrapping, config parsing, doc-path checks that read state the runner's stripped env changes. Each needs an individual audit: what env does it assume, and should the test inject it rather than inherit it?
Every re-included file is CI coverage recovered — the excludes file itself says "an exclusion without a reason is a deleted test with extra steps."
STATUS: excluded and documented; re-inclusion not started.
scripts/ci-test-excludes.txtcurrently excludes 21 files (60 tests), found empirically by CI runs #2–#3. Two classes, two fixes:Class A — subprocess spawns (10 files): tests that
Bun.spawnbun/bash/git fail with "Executable not found in $PATH" inside the runner sandbox but pass in dev shells. Fix: a shared test helper that resolves absolute executable paths (Bun.which("bash")at test setup with a skip-if-absent guard), or export a full PATH in the runner env. Then delete the class-A block from the excludes file.Class B — env-sensitive assertions (11 files): admin bootstrapping, config parsing, doc-path checks that read state the runner's stripped env changes. Each needs an individual audit: what env does it assume, and should the test inject it rather than inherit it?
Every re-included file is CI coverage recovered — the excludes file itself says "an exclusion without a reason is a deleted test with extra steps."
STATUS: excluded and documented; re-inclusion not started.